Exercise-17 #23
Merged
Exercise-17 #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
v-kolesnikov
commented
Aug 24, 2015
v-kolesnikov
commented
- Implemented SuperMemo2 algorithm as Service Object
v-kolesnikov
force-pushed
the
exercise-17
branch
from
cb489c2
to
bc1e59a
Compare
|
Заодно поупрожнялся с rdoc) |
| self.e_factor = 2.5 | ||
| self.interval = 0 | ||
| self.quality = 0 | ||
| self.repetitions = 0 |
There was a problem hiding this comment.
все эти defaults лучше бы сделать default значениями в БД (кроме review_date)
|
А бонусное чего? |
v-kolesnikov
force-pushed
the
exercise-17
branch
2 times, most recently
from
3d6e247
to
2f552b6
Compare
| increment(:correct_answers) if correct_answers < MAX_CORRECT_ANSWERS | ||
| update_attributes(incorrect_answers: 0) | ||
| update_review_date | ||
| def repetition_by_sm2(quality) |
There was a problem hiding this comment.
"повторение по sm2" - это название метод мне тоже всё ещё ни о чём не говорит
There was a problem hiding this comment.
Вторая великая проблема программирования, однако) Незнаю пока как назвать этот метод лучше, пойду продышусь, может что придумаю.
|
не считая замечаний можно мержить |
* Implemented SuperMemo2 algorithm as Service Object
v-kolesnikov
force-pushed
the
exercise-17
branch
from
2f552b6
to
7d636dd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.