Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Fw Write for SGL radios #26

Merged
merged 2 commits into from
Oct 5, 2023
Merged

Fix Fw Write for SGL radios #26

merged 2 commits into from
Oct 5, 2023

Conversation

cifred98
Copy link

Fixed the firmware upload for TYT SGL radios.
The USB callback code wasn't working for me so I made it synchronous. The wrapping of the firmware isn't working yet.
I've tested it only with the Radioddity GD77 flashing OpenRTX on Fedora, not sure if it works on Windows.

Please review it and let me know if there is anything to change.

@v0l
Copy link
Owner

v0l commented Oct 4, 2023

Wow so it was almost correct, the code? I didnt have a GD-77 at the time of writing so i was kinda winging it from other sources and some USB captures. Really cool that you managed to get this to work!

@v0l
Copy link
Owner

v0l commented Oct 4, 2023

std::bit_cast seems to be a problem, can you use something else instead?

@cifred98
Copy link
Author

cifred98 commented Oct 4, 2023

It looks like GCC 9.5.0 had only experimental support for C++20, I've switched it to the built-in bswap.
Good job on making it almost work without having a GD77 to test it!

@v0l v0l merged commit 482eb6f into v0l:main Oct 5, 2023
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants