Axis support #67
Merged
Axis support #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
TODO: Add the axis argument for the packets. |
|
Lets take this version for a test drive: |
v0lta
approved these changes
Oct 12, 2023
| @@ -563,6 +568,7 @@ class MatrixWaverec2(object): | |||
| def __init__( | |||
| self, | |||
| wavelet: Union[Wavelet, str], | |||
| axes: Tuple[int, int] = (-2, -1), | |||
There was a problem hiding this comment.
Breaking change. But okay since pywt uses this ordering.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Major changes:
Breaking changes:
axisoraxesargument appears before arguments related to boundary wavelet support. Pywt does not support boundary wavelets, so to respectpywtargument order we have added the new arguments before anything related to boundary wavelets. This makes it easy to migrate frompywttoptwtand back. Unfortunately, this choice breaks calls to boundary wavelet arguments by order.To migrate call arguments related to boundary wavelets by name. This affects only matrix-fwt and wavelet-packet code that uses boundary wavelet support.