Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG | JOIN SQLite3xTable/SQLite3xColumn support #52

Closed
v1a0 opened this issue Nov 16, 2021 · 1 comment
Closed

BUG | JOIN SQLite3xTable/SQLite3xColumn support #52

v1a0 opened this issue Nov 16, 2021 · 1 comment
Labels
bug Something isn't working or doesn't seems to work right

Comments

@v1a0
Copy link
Owner

v1a0 commented Nov 16, 2021

Sqllex v0.2.0.3 JOIN outdated

Code

        data = self.db.select(
            self.db["users"],
            ['user_id', 'first_name', self.db["user_status"]["name"]],
            JOIN=(
                (self.db["user_status"], ON, self.db["user_status"]["id"] == self.db["users"]["status"]),
            )
        )

Exception

File "sqllex\core\tools\parsers\parsers.py", line 242, in add_join_to_script
    f"{join_method} {' '.join(j_arg for j_arg in _join)} "
TypeError: sequence item 0: expected str instance, SQLite3xTable found

but this code works fine

        data = self.db.select(
            self.db["users"],
            ['user_id', 'first_name', 'user_status.name'],
            JOIN=(
                ("user_status", ON, "user_status.id = users.status"),
            )
        )
@v1a0 v1a0 added the bug Something isn't working or doesn't seems to work right label Nov 16, 2021
@v1a0 v1a0 added this to To do in sqllex-kanban via automation Nov 17, 2021
v1a0 added a commit that referenced this issue Feb 6, 2022
- Fixed issue #59
- Fixed issue #52
- Typing mistakes fixed
@v1a0
Copy link
Owner Author

v1a0 commented Feb 6, 2022

Fixed since v0.2.0.6

@v1a0 v1a0 closed this as completed Feb 6, 2022
sqllex-kanban automation moved this from To do to Done Feb 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working or doesn't seems to work right
Projects
Development

No branches or pull requests

1 participant