Fix installation of incorrect docker version #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ll script for 1.12.6
v1k0d3n
requested changes
Nov 24, 2017
| @@ -53,6 +53,8 @@ for pkg in ${pkg}; do | |||
| fi | |||
| done | |||
|
|
|||
| curl https://raw.githubusercontent.com/rancher/install-docker/master/1.12.6.sh | bash | |||
There was a problem hiding this comment.
I would like to put this into a conditional rather than issuing a reinstall each time. according to dockers documentation (and i've experienced this first hand) reinstalling without removal first can cause some really strange issues. other than that, good find.
we could actually take this script, own it, and add the conditional to the script. i don't typically like own things, but in this case, it could prevent issues in the case where they pull the script for some reason.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes for installing an incompatible docker version (1.13.1) using docker.io. The fixes use an Rancher written bash script to install 1.12.6.