-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to 4.1+ qBittorrent APIs #36
Conversation
Thanks for the awesome contribution, @Shaance! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code changes are looking good.
I guess we can live with this breaking 3.1x. The version is quite old anyway. An older (current) version of this project can be used for supporting 3.1.x.
Could you go ahead and update the README file to reflect the version support?
@v1k45 Updated the README and removed the dead code :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just tested this, few methods aren't working, otherwise everything works fine.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the awesome work! I'll bump the package version and deploy it to PyPI soon.
This update is live in 0.4.1 🎉 |
No description provided.