Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a timeout option to the Client #42

Merged
merged 1 commit into from Nov 25, 2021
Merged

Conversation

esanchezm
Copy link
Contributor

Hi everyone!

I just decided to create my own remote client desktop for qBittorrent and found your awesome library. I think it's lacking an option to setup the timeout as by default and according to requests library documentation:

Most requests to external servers should have a timeout attached, in case the server is not responding in a timely manner. By default, requests do not time out unless a timeout value is set explicitly. Without a timeout, your code may hang for minutes or more.

I'm interesting on a timeout to avoid my application to hang forever. I think it should be useful to define it in the Client constructor. Looking forward for your feedback

Copy link
Owner

@v1k45 v1k45 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I finally got the time to check it out. Apologies for the long delay 😬

@v1k45 v1k45 merged commit 731a6d8 into v1k45:master Nov 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants