Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

trojan fallbacks 中"alpn"无效，此bug是否有计划修复？ #1282

Closed
lxhao61 opened this issue Sep 21, 2021 · 3 comments · Fixed by #1286
Closed

trojan fallbacks 中"alpn"无效，此bug是否有计划修复？ #1282

lxhao61 opened this issue Sep 21, 2021 · 3 comments · Fixed by #1286

Comments

@lxhao61
Copy link

lxhao61 commented Sep 21, 2021 •
edited

trojan fallbacks 中"alpn"无效，此bug一直存在，一直没有解决，不知道是否有计划修复？
此bug虽然只影响使用类似nginx做回落服务（nginx 的 h2c 服务不能同时兼容 http/1.1，需要写两行 listen，分别用于http/1.1和 h2c），但因为使用nginx做回落服务的不少，还是建议能修复。
若无计划修复，建议更正官方配置文档，明确告知trojan fallbacks 中"alpn"无效，即trojan fallbacks中回落h2与http/1.1不能分开。若使用类似nginx做回落服务，tlsSettings中"alpn"不能使用默认值 ["h2", "http/1.1"]，要h2或http/1.1二选一（不能共存）；以便trojan fallbacks仅回落h2或http/1.1。
此bug造成的问题见如下：
(XTLS/Xray-core#708)
(XTLS/Xray-core#573)
@kslr
Copy link
Contributor

kslr commented Sep 21, 2021

我认为可以简化此处逻辑只保留 fallback Address and port
@xiaokangwang 你怎么看

@AkinoKaede AkinoKaede mentioned this issue Sep 24, 2021
Merged
@lxhao61 lxhao61 mentioned this issue Sep 27, 2021
Closed
@lxhao61 lxhao61 changed the title trojan Fallback 中"alpn"无效，此bug是否有计划修复？ trojan fallbacks 中"alpn"无效，此bug是否有计划修复？ Sep 27, 2021
@GeorgeRudd
Copy link

请问这个bug有计划要修复吗 我也觉得应该要在文档里注明一下...

@kslr
Copy link
Contributor

kslr commented Nov 14, 2021

请问这个bug有计划要修复吗 我也觉得应该要在文档里注明一下...

已修复

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix: Trojan fallback cannot get ALPN AkinoKaede/v2ray-core
3 participants
@kslr @lxhao61 @GeorgeRudd