fix a bug in /build.sh #1041
Merged
fix a bug in /build.sh #1041
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… could get non-existing file paths, which in turn fails the building process. This commit fixes that bug by discarding the entire `for` loop and running solely the `find` command with the `gzip` commanded in the `-exec` clause after file paths filtered by `-name` and `-type` predicates.
|
Good catch! Have you ever tested it? |
Yes, I've tested the case of |
Gaojianli
pushed a commit
that referenced
this pull request
Nov 3, 2023
… could get non-existing file paths, which in turn fails the building process. (#1041)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the value of $CurrentDir contains whitespaces, $file in
forloop could get non-existing file paths, which in turn fails the building process.This commit fixes that bug by discarding the entire
forloop and running solely thefindcommand with thegzipcommanded in the-execclause after file paths filtered by-nameand-typepredicates.