Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mpi-operator] Fix mpijob crd schema + cluster role name #573

Merged
merged 4 commits into from
Apr 29, 2021

Conversation

Hedingber
Copy link
Contributor

@Hedingber Hedingber commented Apr 28, 2021

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove irrelevant fields.]

  • Chart Version bumped
  • Title of the PR starts with chart name (e.g. [mychartname])

Description:

In #559 I added the schema cause otherwise it wouldn't let install the CRD on k8s>=1.19. the schema I used there was just taken from the validation block which I thought back then to be aligned.
Apparently, this schema is missing A LOT of stuff, and what practically happening is that when you create a custom object pretty much all of it is getting pruned .
The actual schema includes a Pod template, and currently there is no way to use already defined structure ( kubernetes/kubernetes#62872 and kubernetes/kubernetes#82292), I'm not willing to duplicate the whole pod template schema since it's huge, so I simply added x-kubernetes-preserve-unknown-fields: true which just turn off field pruning (I assume at some point k8s won't let us do that, but also at that point they will hopefully resolve those issues so we will be able to re-use stuff)

Also, fixed the cluster role name to use the correct value (before it was assigned to a value different than the role binding, so was practically not getting the binding to the cluster role)

@omesser omesser self-requested a review April 28, 2021 22:09
@Hedingber Hedingber changed the title [mpi-operator] Fix mpijob crd schema [mpi-operator] Fix mpijob crd schema + cluster role name Apr 28, 2021
@Hedingber Hedingber merged commit 736a4cd into v3io:development Apr 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants