Updated Android SDK version #261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zazo032
requested changes
Sep 27, 2022
There was a problem hiding this comment.
🥇 Thanks for the contribution!
Since version 12.5.0, Android 13 is now officially supported by Intercom, I think we should also make some small changes to the README.md file:
- In the optional permissions for Android section, add:
<uses-permission android:name="android.permission.POST_NOTIFICATIONS" />- In the Push notifications setup section, add extra steps for Android setup:
- Steps for Android notifications setup: https://developers.intercom.com/installing-intercom/docs/android-fcm-push-notifications
- We could also add that for push notifications to work, user might have to grant the notification permission in iOS or Android 13+ with a plugin like permission_handler
Co-authored-by: Cristian Zazo <cristian.zazo@gmail.com>
|
Thanks, will apply the changes :) |
|
I updated the README.md and from what I can see right now the |
Zazo032
approved these changes
Sep 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was issue with previous version of Android SDK that it used wrong text colors for dark backgrounds. I got response from Intercom support team, that updating to 12.5.1 should solve that.