Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V7 1539 - Multi Labels Dataset #201

Merged
merged 17 commits into from Sep 21, 2021
Merged

V7 1539 - Multi Labels Dataset #201

merged 17 commits into from Sep 21, 2021

Conversation

FrancescoSaverioZuppichini
Copy link
Contributor

Since the APIs are not test-friendly, the following code is not tested. It should work, please have a look. ClassificationDataset now returns a Tensor of size 1 for single-label classification and a Tensor of size [C,1] for multi-label classification where C is the number of classes

max_workers is always bound between `MAX_WORKERS` and the current system cpu count. `MAX_WORKERS` has been set to 5
missing `os` import
passing `max_workers` as parameter, if `None` `concurrent.futures.ThreadPoolExecutor` will use the system cpu number * 5. From the [doc](https://docs.python.org/3/library/concurrent.futures.html)

Changed in version 3.5: If max_workers is None or not given, it will default to the number of processors on the machine, multiplied by 5, assuming that ThreadPoolExecutor is often used to overlap I/O instead of CPU work and the number of workers should be higher than the number of workers for ProcessPoolExecutor.
removed unused imports
Copy link
Contributor

@Fl4m3Ph03n1x Fl4m3Ph03n1x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some documentation could be added. Other than that, LGTM

darwin/torch/dataset.py Outdated Show resolved Hide resolved
darwin/torch/dataset.py Outdated Show resolved Hide resolved
@andreaazzini andreaazzini merged commit 32a6549 into master Sep 21, 2021
@andreaazzini andreaazzini deleted the V7-1539 branch September 21, 2021 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants