V7 2428 harmonize api for clientpy #287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fl4m3Ph03n1x
requested review from
kamilc,
andreaazzini and
FrancescoSaverioZuppichini
simedw
reviewed
Nov 25, 2021
Fl4m3Ph03n1x
changed the title
andreaazzini
requested changes
Dec 1, 2021
There was a problem hiding this comment.
Requested a few changes already, but pretty much:
- in the new client functions, I would try and be consistent by always returning the
response - there are some naming conventions I personally don't like (
the_{}) - we are not really introducing any tests for
client.py - some things feel a bit weird, like using
castor importingloggingin all tests. Are we sure there is no other way?
darwin/client.py
Outdated
| team_slug: str | ||
| Team slug of the dataset. | ||
| """ | ||
| self._put(f"datasets/{dataset_id}/archive", payload={}, team=team_slug) |
There was a problem hiding this comment.
We're probably not using the response when we call archive_remote_dataset, but I would actually return the response for API consistency. What do you think?
There was a problem hiding this comment.
I would go even further and actually use a DatasetIdentifier iin every place we are using a slug or an id. However, I think I made enough breaking changes as is for 1 PR :D
There was a problem hiding this comment.
Ticket created for this topic:
https://linear.app/v7labs/issue/V7-2547/harmonization-part-2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
Implementation of changes from RFC:
https://www.notion.so/v7labs/API-Harmonization-for-client-py-0248a627bad144109bf64f078134cecf
This PR focuses on:
reponse.okinstead of checking forresponse.status_code != 200Missing: