Video annotation split branch #454
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreaazzini
requested review from
owencjones and
Nathanjp91
and removed request for
andreaazzini
|
@ChristofferEdlund is this still a current issue? If so, can you ping me in linear or slack, and I'll see it on to the backlog, seeing as you've done much of the work some time ago. |
owencjones
added
stale
Nathanjp91
approved these changes
Mar 31, 2023
|
I think this makes sense, but I'm worried that it might be considered breaking. Also, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pulling video data with --video-frames argument only transform the videos into correct format, but not the annotations. Generating a miss-match between the two. This PR addresses this by also transforming the annotations into a format that takes the parsed image frames into account.