[IO-1754] Darwin-py v2 Dogfooding refactors #670
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IO-1754 Renaming Refactor
|
owencjones
approved these changes
Sep 29, 2023
| @@ -0,0 +1,4 @@ | |||
| from darwin.future.core.datasets.create_dataset import * | |||
There was a problem hiding this comment.
In general, I tend to do these specifically, e.g.
from module import Thing1, Thing2, Thing3as it can avoid dep issues later, with name clashes and such.
I'd leave it for now unless you have good chance to fix it.
| @@ -0,0 +1,5 @@ | |||
| # Can't import * in this module because of a circular import problem specific to teams | |||
There was a problem hiding this comment.
Specific import might fix this, but again, don't break your back on it.
owencjones
reviewed
Oct 1, 2023
|
|
||
|
|
||
| def get_team_raw(session: Session, url: str) -> JSONType: | ||
| """Returns the team with the given slug in raw JSON format""" |
There was a problem hiding this comment.
I'll ticket including returns and params in doc blocks, but leave for now
owencjones
pushed a commit
that referenced
this pull request
Oct 10, 2023
* client refactor * item object rename * delete/create classmethods * core item rename * meta object rename * Client naming consistency * remove useless asserts * remove useless asserts * collect refactor * mypy cleanup * streamlining * expanding on exceptions * __init__.py backend import changes * team backend restructure for circular reference * comment * changes to collect operation, now invalidates cache if adding to query * restructure exceptions module
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Dogfooding of darwin-py v2 code revealed some streamlining and refactors to make
Solution
List of things changed
Changelog
Darwin py v2 futures module refactored for streamlined useage