Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IO-1661][external] Error messages were not clear to customers #674

Merged
merged 3 commits into from
Oct 3, 2023

Conversation

owencjones
Copy link
Contributor

Problem

COCO iscrowd error messages were not clear to customers.

Solution

Have changed the messages to explain more verbosely what the issue is with a crowd import.

Changelog

coco.py now uses logger, and the message is more verbose

@linear
Copy link

linear bot commented Oct 2, 2023

IO-1661 Request: Improve error message for COCO import

Product Request Form submission from Moe

Is this a V1 or V2 issue, or both?
V2

​What is your request?
Hey team, we’ve had some cases of customers messaging us when attempting to import complex polygons in COCO format. When doing so, they receive this error message - "Warning, unsupported RLE, skipping". I know that this error message is correct in this instance since they have iscrowd set to 1, however, it sometimes misleads customers into thinking that we support RLE encoding for COCO.
Is it possible to make the error message more candid so that customers don’t misunderstand? If so, I think a message like - "Warning, RLE encoding is not supported, skipping".

​What are the acceptance criteria?
This change is made in some way (i.e. the error message is more candid).

​Which product area is this request is applicable to (specify a team if known)?
IO

How important is this request?
High - not vital, but adds significant financial or customer value

Do you have any deadline for this request (if deadline applicable, specify why)?
Sooner rather than later would be nice.

Any additional info / Specify why Urgent or High:
This error message has caused several customers to misunderstand our support for complex polygons so we've had to spend additional time and resources helping them understand that complex polygons are not supported in COCO, for example. From there, we usually have to spend time assisting them with a workaround of some kind, if possible.

Copy link
Contributor

@Nathanjp91 Nathanjp91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One thing to consider

darwin/importer/formats/coco.py Show resolved Hide resolved
@owencjones owencjones changed the title [IO-1661][external] Error messages were not to customers [IO-1661][external] Error messages were not clear to customers Oct 3, 2023
@NPatel1980
Copy link

QA passed, paired with Owen and observed the new message.

@owencjones owencjones merged commit a4ad270 into master Oct 3, 2023
9 checks passed
@owencjones owencjones deleted the io-1661 branch October 3, 2023 16:16
owencjones added a commit that referenced this pull request Oct 10, 2023
* Error messages improved.

* Update to error message

* Correct typo

---------

Co-authored-by: Owen <owen@owencjones.co.uk>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants