Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tag, untag an Item / ItemQuery object #733

Merged
merged 9 commits into from Nov 30, 2023
Merged

tag, untag an Item / ItemQuery object #733

merged 9 commits into from Nov 30, 2023

Conversation

saurbhc
Copy link
Member

@saurbhc saurbhc commented Nov 23, 2023

Problem

Feature request of tagging/untagging an Item

Solution

Add tag, untag methods in both Item and ItemQuery objects.

Changelog

Ability to tag, untag an Item via Item or ItemQuery objects.

@saurbhc saurbhc added the enhancement New feature or request label Nov 23, 2023
@saurbhc saurbhc self-assigned this Nov 23, 2023
Copy link

linear bot commented Nov 23, 2023

PY-543 Tag

  • Should only work with ids
  • Tag object will be part of following milestone. (will update the meta items to use UUID | Tag when the latter has been created

https://docs.v7labs.com/reference/workflow-items-tag-items

Acceptance Criteria:

ItemQuery.tag(tag_uuid) # Batch operation that tags entire query
Item.tag(tag_uuid)
ItemQuery.untag(tag_uuid)
item.untag(tag_uuid)

Will also require the creation of 2 core backend api calls to tag and untag

def tag_items(client, team_slug, tag_id, filters):
    ...
def untag_items(client, team_slug, tag_id, filters):
    ...

@saurbhc saurbhc marked this pull request as ready for review November 23, 2023 16:59
@saurbhc saurbhc changed the title tag/untag an Item/ItemQuery object tag, untag an Item and ItemQuery object Nov 23, 2023
@saurbhc saurbhc changed the title tag, untag an Item and ItemQuery object tag, untag an Item / ItemQuery object Nov 23, 2023
saurbhc and others added 6 commits November 29, 2023 12:20
Co-authored-by: John Wilkie <124276291+JBWilkie@users.noreply.github.com>
Co-authored-by: John Wilkie <124276291+JBWilkie@users.noreply.github.com>
Co-authored-by: John Wilkie <124276291+JBWilkie@users.noreply.github.com>
Co-authored-by: John Wilkie <124276291+JBWilkie@users.noreply.github.com>
Co-authored-by: John Wilkie <124276291+JBWilkie@users.noreply.github.com>
Copy link
Contributor

@JBWilkie JBWilkie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested as well

Copy link
Contributor

@Nathanjp91 Nathanjp91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@saurbhc saurbhc merged commit 7aa1fb6 into master Nov 30, 2023
13 checks passed
@saurbhc saurbhc deleted the PY-543 branch November 30, 2023 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants