Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[py-578][py-580] get properties endpoints #747

Merged
merged 43 commits into from Dec 13, 2023
Merged

[py-578][py-580] get properties endpoints #747

merged 43 commits into from Dec 13, 2023

Conversation

Nathanjp91
Copy link
Contributor

Problem

Lacking support for properties endpoints

Solution

adds in functions for requesting properties objects
def get_property_by_id(...)
def get_team_properties(...)
def get_team_full_properties(...) -> wrapper around get_team_properties that includes options by default

Changelog

properties endpoints supported in darwin.future.core

Copy link

linear bot commented Dec 12, 2023

@Nathanjp91 Nathanjp91 changed the title [py-578] get properties endpoints [py-578][py-575] get properties endpoints Dec 12, 2023
@Nathanjp91 Nathanjp91 changed the title [py-578][py-575] get properties endpoints [py-578][py-580] get properties endpoints Dec 12, 2023
Copy link

linear bot commented Dec 12, 2023

@v7labs v7labs deleted a comment from linear bot Dec 12, 2023
Copy link
Member

@saurbhc saurbhc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QueryParams change, looks like the API can't process True as query param, but works with "true".

Copy link
Member

@saurbhc saurbhc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thank you 💯

@Nathanjp91 Nathanjp91 merged commit 009ba15 into master Dec 13, 2023
13 checks passed
@saurbhc saurbhc deleted the py-578 branch December 13, 2023 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants