New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[py-578][py-580] get properties endpoints #747
Merged
Merged
+195
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nathanjp91
changed the title
[py-578] get properties endpoints
[py-578][py-575] get properties endpoints
Dec 12, 2023
Nathanjp91
changed the title
[py-578][py-575] get properties endpoints
[py-578][py-580] get properties endpoints
Dec 12, 2023
saurbhc
reviewed
Dec 13, 2023
saurbhc
requested changes
Dec 13, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
QueryParams change, looks like the API can't process True
as query param, but works with "true"
.
This was referenced Dec 13, 2023
saurbhc
approved these changes
Dec 13, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Thank you 💯
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Lacking support for properties endpoints
Solution
adds in functions for requesting properties objects
def get_property_by_id(...)
def get_team_properties(...)
def get_team_full_properties(...)
-> wrapper aroundget_team_properties
that includes options by defaultChangelog
properties endpoints supported in darwin.future.core