New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PY-576][PY-581] Create + Update of properties #756
Conversation
e2e_tests/data/coco/to/output.json
Outdated
@@ -85,13 +85,13 @@ | |||
], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
e2e tests broke again because of the ordering. Will put in a ticket for a fix on the coco exporter to always sort before saving.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
and it reverted itself and had to be redone.
def to_create_endpoint( | ||
self, | ||
) -> dict: | ||
if not getattr(self, "annotation_class_id") or self.annotation_class_id is None: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rest of the fields are non-optional so they'll already be captured by ValidationErrors
@@ -4,7 +4,7 @@ | |||
"editor.formatOnSave": true, | |||
"editor.tabSize": 4, | |||
"editor.codeActionsOnSave": { | |||
"source.organizeImports": true, | |||
"source.organizeImports": "explicit" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
vscode keeps saving the file like this even if I revert it. So I assume it's vscode deprecating or changing a naming convention
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
I can confirm that my vscode updated the same change!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great Work!! The E2E tests seem very helpful. :)
Problem
No Support exists for creation or updating of properties
Solution
Added functions for supporting creation and updating
Also added in e2e tests to support these new features in preparation for support of imports
To Do
Changelog
Creation and updating of properties now possible in darwin.future