[PY-646][external] Resolved precision bug #763
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
owencjones
approved these changes
Jan 8, 2024
| def update_property(self, team_slug: Optional[str], params: Union[FullProperty, JSONDict]) -> FullProperty: | ||
| def update_property( | ||
| self, team_slug: Optional[str], params: Union[FullProperty, JSONDict] | ||
| ) -> FullProperty: | ||
| darwin_config = DarwinConfig.from_old(self.config) | ||
| future_client = ClientCore(darwin_config) | ||
|
|
||
| return update_property_future( |
There was a problem hiding this comment.
Slight naming issue here, which is probably ok to leave, but a Future is a thing in itself, similar to a Javascript Promise, so worth bearing in mind in erm... future
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
As described in PY-646, sufficiently small polygons can result in an assertion error due to rounding 4 decimal place floats to integers. This can cause the minimum & maximum x or y coordinates of the enclosing bounding box to be equal, resulting in a "flat" bbox with no area that is therefore invalid
Solution
Pass the
roundingarg asFalseto prevent thisChangelog
Resolved rounding error for very small polygons in Pytorch dataloaders