Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PLA-801][external] fetch_remote_files() is called with an old, V1 argument #809

Merged
merged 3 commits into from Apr 12, 2024

Conversation

JBWilkie
Copy link
Contributor

@JBWilkie JBWilkie commented Apr 4, 2024

Problem

  • Changes made to darwin-py in 0.8.58 to remove V1 code removed a V1 backwards compatibility "handler" for an older version of a filter parameter when retrieving a list of remote files in fetch_remote_files()

Solution

  • Re-add this backward compatibility and update all invocations of fetch_remote_files() to use item_names instead of filenames

Changelog

  • Re-added backward compatibility for a V1 filter parameter when fetching remote files

@JBWilkie JBWilkie requested a review from saurbhc April 4, 2024 11:57
Copy link
Member

@saurbhc saurbhc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🙏

@JBWilkie JBWilkie merged commit 9642769 into master Apr 12, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants