[DAR-2639][External] Add data & tests for in-platform model training #872
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JBWilkie
commented
Jun 19, 2024
| @@ -339,7 +344,7 @@ def _download_single_slot_from_json_annotation( | |||
| image_url = image["url"] | |||
| image_filename = image["file_name"] | |||
| suffix = Path(image_filename).suffix | |||
| stem = annotation_path.stem | |||
| stem = Path(annotation.filename).stem | |||
There was a problem hiding this comment.
In cases where there are duplicate item names, the annotation_path.stem will have an _n appended, which will cause darwin-py to fail to find the corresponding item. Therefore, use the item name since this will not have a _n appended for uniqueness
dorfmanrobert
approved these changes
Jun 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
There are no tests for in-platform model training functionality
Solution
Add data & tests to support testing of darwin-py functionality used in in-platform model training. In addition to this:
convert_xyxy_to_bounding_boxused by model trainingget_annotations()to read local items from the item name, not the annotation file nameChangelog
(Will appear in release docs)