Skip to content

Commit

Permalink
[ia32] Enable embedded builtins and kRootRegister
Browse files Browse the repository at this point in the history
Bug: v8:6666
Change-Id: Idcccd5467d48263f54cbb5e3c197543f8a2119c8
Reviewed-on: https://chromium-review.googlesource.com/c/1286683
Reviewed-by: Ross McIlroy <rmcilroy@chromium.org>
Reviewed-by: Michael Hablich <hablich@chromium.org>
Reviewed-by: Michael Achenbach <machenbach@chromium.org>
Commit-Queue: Jakob Gruber <jgruber@chromium.org>
Cr-Commit-Position: refs/heads/master@{#56808}
  • Loading branch information
schuay authored and Commit Bot committed Oct 19, 2018
1 parent d853a47 commit 1e748ba
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -83,9 +83,9 @@ declare_args() {
v8_enable_fast_mksnapshot = false

# Enable embedded builtins.
# TODO(jgruber,v8:6666): Support ia32 and maybe MSVC.
v8_enable_embedded_builtins = v8_use_snapshot && v8_current_cpu != "x86" &&
!is_aix && (!is_win || is_clang)
# TODO(v8:6666): Support no-snapshot builds, aix and MSVC.
v8_enable_embedded_builtins =
v8_use_snapshot && !is_aix && (!is_win || is_clang)

# Enable code-generation-time checking of types in the CodeStubAssembler.
v8_enable_verify_csa = false
Expand Down

0 comments on commit 1e748ba

Please sign in to comment.