Skip to content

Commit

Permalink
[ycm] The YouCompleteMe configuration is not VIM specific.
Browse files Browse the repository at this point in the history
Rename tools/vim/v8.ycm_extra_conf.py to .ycm_extra_conf.py, so every
YCM plugin (no matter if it's VIM or Emacs) should pick it up
automatically.

Also move the common tools/vim/ninja_output.py to tools/ninja/ as it's
also not related to VIM.

Review URL: https://codereview.chromium.org/904143003

Cr-Commit-Position: refs/heads/master@{#26602}
  • Loading branch information
bmeurer authored and Commit bot committed Feb 12, 2015
1 parent fb55eae commit 42c30b8
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 7 deletions.
8 changes: 2 additions & 6 deletions tools/vim/v8.ycm_extra_conf.py → .ycm_extra_conf.py
Expand Up @@ -9,11 +9,7 @@
# 1. Install YCM [https://github.com/Valloric/YouCompleteMe]
# (Googlers should check out [go/ycm])
#
# 2. Point to this config file in your .vimrc:
# let g:ycm_global_ycm_extra_conf =
# '<v8_root>/tools/vim/v8.ycm_extra_conf.py'
#
# 3. Profit
# 2. Profit
#
#
# Usage notes:
Expand Down Expand Up @@ -129,7 +125,7 @@ def GetClangCommandFromNinjaForFilename(v8_root, filename):
# try to use the default flags.
return v8_flags

sys.path.append(os.path.join(v8_root, 'tools', 'vim'))
sys.path.append(os.path.join(v8_root, 'tools', 'ninja'))
from ninja_output import GetNinjaOutputDirectory
out_dir = os.path.realpath(GetNinjaOutputDirectory(v8_root))

Expand Down
File renamed without changes.
2 changes: 1 addition & 1 deletion tools/vim/ninja-build.vim
Expand Up @@ -47,7 +47,7 @@ def path_to_build_dir(configuration):
"""Returns <v8_root>/<output_dir>/(Release|Debug)."""

v8_root = path_to_source_root()
sys.path.append(os.path.join(v8_root, 'tools', 'vim'))
sys.path.append(os.path.join(v8_root, 'tools', 'ninja'))
from ninja_output import GetNinjaOutputDirectory
return GetNinjaOutputDirectory(v8_root, configuration)

Expand Down

0 comments on commit 42c30b8

Please sign in to comment.