Skip to content

Commit

Permalink
Version 5.1.281.64 (cherry-pick)
Browse files Browse the repository at this point in the history
Merged 54245bd

Debugger: fix crash in DebugEvaluate

BUG=chromium:614019
LOG=N
R=yangguo@chromium.org
NOTRY=true
NOPRESUBMIT=true

Review-Url: https://codereview.chromium.org/2049973003
Cr-Commit-Position: refs/branch-heads/5.1@{#75}
Cr-Branched-From: 167dc63-refs/heads/5.1.281@{#1}
Cr-Branched-From: 03953f5-refs/heads/master@{#35282}
  • Loading branch information
alexkozy authored and Commit bot committed Jun 10, 2016
1 parent 5ff2778 commit 4bf0f33
Show file tree
Hide file tree
Showing 3 changed files with 42 additions and 2 deletions.
2 changes: 1 addition & 1 deletion include/v8-version.h
Expand Up @@ -11,7 +11,7 @@
#define V8_MAJOR_VERSION 5
#define V8_MINOR_VERSION 1
#define V8_BUILD_NUMBER 281
#define V8_PATCH_LEVEL 63
#define V8_PATCH_LEVEL 64

// Use 1 for candidates and 0 otherwise.
// (Boolean macro values are not supported by all preprocessors.)
Expand Down
3 changes: 2 additions & 1 deletion src/debug/debug-evaluate.cc
Expand Up @@ -247,7 +247,8 @@ void DebugEvaluate::ContextBuilder::MaterializeReceiver(
// 'this' is allocated in an outer context and is is already being
// referenced by the current function, so it can be correctly resolved.
return;
} else if (local_function->shared()->scope_info()->HasReceiver()) {
} else if (local_function->shared()->scope_info()->HasReceiver() &&
!frame_->receiver()->IsTheHole()) {
recv = handle(frame_->receiver(), isolate_);
}
JSObject::SetOwnPropertyIgnoreAttributes(target, name, recv, NONE).Check();
Expand Down
39 changes: 39 additions & 0 deletions test/mjsunit/es6/debug-evaluate-receiver-before-super.js
@@ -0,0 +1,39 @@
// Copyright 2016 the V8 project authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.

// Flags: --expose-debug-as debug

// Test that debug-evaluate doesn't crash when this is used before super() call
// in constructor.

Debug = debug.Debug

var result;

function listener(event, exec_state, event_data, data)
{
try {
if (event == Debug.DebugEvent.Break) {
result = exec_state.frame(0).evaluate("this.a").value();
}
} catch (e) {
result = e.message;
}
}

Debug.setListener(listener);

class A { constructor () { this.a = 239; } }
class B extends A {
constructor () {
debugger;
assertEquals("Cannot read property 'a' of undefined", result);
super();
debugger;
assertEquals(239, result);
}
}
new B();

Debug.setListener(null);

0 comments on commit 4bf0f33

Please sign in to comment.