Skip to content

Commit

Permalink
Fix visiblity rules for configs enforced by the latest GN version.
Browse files Browse the repository at this point in the history
Prior versions of GN had a bug (gn:22) where visibility rules
for configs weren't being enforced properly.

This CL tweaks the visibility settings of some configs to
conform to the latest version.

Change-Id: Ic5d827a1f2774278d3894f67fe52bfca836c0409
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2360909
Commit-Queue: Dirk Pranke <dpranke@google.com>
Reviewed-by: Adam Klein <adamk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#69463}
  • Loading branch information
dpranke authored and Commit Bot committed Aug 18, 2020
1 parent e3bbf2b commit 7c182bd
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 5 deletions.
12 changes: 8 additions & 4 deletions BUILD.gn
Expand Up @@ -369,7 +369,8 @@ v8_toolset_for_shell = "host"
#

config("internal_config_base") {
visibility = [ ":*" ] # Only targets in this file can depend on this.
# Only targets in this file and its subdirs can depend on this.
visibility = [ "./*" ]

configs = [ ":v8_tracing_config" ]

Expand All @@ -382,7 +383,8 @@ config("internal_config_base") {

config("internal_config") {
defines = []
visibility = [ ":*" ] # Only targets in this file can depend on this.
# Only targets in this file and its subdirs can depend on this.
visibility = [ "./*" ]

configs = [
"//build/config/compiler:wexit_time_destructors",
Expand Down Expand Up @@ -502,7 +504,8 @@ config("v8_header_features") {
# Put defines here that are only used in our internal files and NEVER in
# external headers that embedders (such as chromium and node) might include.
config("features") {
visibility = [ ":*" ] # Only targets in this file can depend on this.
# Only targets in this file and its subdirs can depend on this.
visibility = [ "./*" ]

defines = []

Expand Down Expand Up @@ -632,7 +635,8 @@ config("features") {
}

config("toolchain") {
visibility = [ ":*" ] # Only targets in this file can depend on this.
# Only targets in this file and its subdirs can depend on this.
visibility = [ "./*" ]

defines = []
cflags = []
Expand Down
2 changes: 1 addition & 1 deletion third_party/inspector_protocol/BUILD.gn
Expand Up @@ -5,7 +5,7 @@
import("../../gni/v8.gni")

config("crdtp_config") {
visibility = [ "../../src/inspector:*" ]
visibility = [ "../../src/inspector:*", ":*" ]
configs = [ "../../:internal_config" ]
include_dirs = [ "../../include" ]
}
Expand Down

0 comments on commit 7c182bd

Please sign in to comment.