Skip to content

Commit

Permalink
[API] Remove second OnCriticalMemoryPressure
Browse files Browse the repository at this point in the history
Remove the deprecated OnCriticalMemoryPressure method with receives an
informative parameter.

R=mlippautz@chromium.org

Bug: chromium:634547
Change-Id: I932c3b5030291294dd340362f0b20d374e3067c0
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3780533
Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
Commit-Queue: Clemens Backes <clemensb@chromium.org>
Cr-Commit-Position: refs/heads/main@{#83254}
  • Loading branch information
backes authored and V8 LUCI CQ committed Sep 16, 2022
1 parent c582eb4 commit 8b87039
Showing 1 changed file with 0 additions and 12 deletions.
12 changes: 0 additions & 12 deletions include/v8-platform.h
Expand Up @@ -943,18 +943,6 @@ class Platform {
*/
virtual void OnCriticalMemoryPressure() {}

/**
* Enables the embedder to respond in cases where V8 can't allocate large
* memory regions. The |length| parameter is the amount of memory needed.
* Returns true if memory is now available. Returns false if no memory could
* be made available. V8 will retry allocations until this method returns
* false.
*
* Embedder overrides of this function must NOT call back into V8.
*/
V8_DEPRECATED("Use the method without informative parameter")
virtual bool OnCriticalMemoryPressure(size_t length) { return false; }

/**
* Gets the number of worker threads used by
* Call(BlockingTask)OnWorkerThread(). This can be used to estimate the number
Expand Down

0 comments on commit 8b87039

Please sign in to comment.