Skip to content

Commit

Permalink
[compiler] Fix typing of NumberToString operator.
Browse files Browse the repository at this point in the history
It must be monotone.

R=bmeurer@chromium.org

Bug: v8:7354
Change-Id: I08dcd3333518029eef08c074c2b91b5c20ad699e
Reviewed-on: https://chromium-review.googlesource.com/880982
Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
Commit-Queue: Georg Neis <neis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#50801}
  • Loading branch information
GeorgNeis authored and Commit Bot committed Jan 23, 2018
1 parent 6bcf57e commit 8bfbe25
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/compiler/operation-typer.cc
Expand Up @@ -507,7 +507,7 @@ Type* OperationTyper::NumberToInt32(Type* type) {

Type* OperationTyper::NumberToString(Type* type) {
DCHECK(type->Is(Type::Number()));

if (type->IsNone()) return type;
if (type->Is(Type::NaN())) return singleton_NaN_string_;
if (type->Is(cache_.kZeroOrMinusZero)) return singleton_zero_string_;
return Type::SeqString();
Expand Down

0 comments on commit 8bfbe25

Please sign in to comment.