Skip to content

Commit

Permalink
[compiler] Gracefully handle an unsupported situation
Browse files Browse the repository at this point in the history
... by skipping the optimization instead of CHECK-failing.

Bug: v8:12188
Change-Id: I6709bf1c55506f3d12886efbfbb9934788cd02ce
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3148132
Auto-Submit: Georg Neis <neis@chromium.org>
Commit-Queue: Jakob Gruber <jgruber@chromium.org>
Reviewed-by: Jakob Gruber <jgruber@chromium.org>
Cr-Commit-Position: refs/heads/main@{#76741}
  • Loading branch information
GeorgNeis authored and V8 LUCI CQ committed Sep 9, 2021
1 parent a5f31d0 commit 9a60704
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions src/objects/lookup.cc
Expand Up @@ -1527,8 +1527,8 @@ base::Optional<PropertyCell> ConcurrentLookupIterator::TryGetPropertyCell(
DisallowGarbageCollection no_gc;

Map holder_map = holder->map();
CHECK(!holder_map.is_access_check_needed());
CHECK(!holder_map.has_named_interceptor());
if (holder_map.is_access_check_needed()) return {};
if (holder_map.has_named_interceptor()) return {};

GlobalDictionary dict = holder->global_dictionary(kAcquireLoad);
base::Optional<PropertyCell> cell =
Expand Down

0 comments on commit 9a60704

Please sign in to comment.