Skip to content

Commit

Permalink
[github] Close PRs created on the V8 GitHub mirror automatically
Browse files Browse the repository at this point in the history
As per https://v8.dev/docs/contribute: Code contributions to v8 are
done through Gerrit, not using GitHub pull requests.

Unfortunately not a lot of people seem to read this and end up opening
PRs on the github v8 mirror which then needs to be closed manually:
https://github.com/v8/v8/pulls?q=is%3Apr+is%3Aclosed

Rather than manually closing these PRs, once we add this config, we
can make the google GitHub bot automatically do this. See:
https://opensource.google/docs/github/disable-features/#close

Bug: v8:11301
Change-Id: I2b55f60cb095bd4d3e26e5a096dac2c1c886ba31
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2617080
Reviewed-by: Hannes Payer <hpayer@chromium.org>
Commit-Queue: Sathya Gunasekaran  <gsathya@chromium.org>
Cr-Commit-Position: refs/heads/master@{#72032}
  • Loading branch information
gsathya authored and Commit Bot committed Jan 12, 2021
1 parent 1f7721b commit bf6a80f
Showing 1 changed file with 13 additions and 0 deletions.
13 changes: 13 additions & 0 deletions .github/mistaken-pull-closer.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
# `true` will close all PRs.
filters:
- true

# The message to post to the closed PR.
commentBody: |
Thanks for your contribution! Unfortunately, we don't use GitHub pull
requests to manage code contributions to this repository. Instead, please
see https://v8.dev/docs/contribute which provides full instructions on
how to get involved.
# Whether to add a label to the closed PR.
addLabel: false

0 comments on commit bf6a80f

Please sign in to comment.