Skip to content

Commit

Permalink
[jumbo]: allow cctest jumbo mode builds
Browse files Browse the repository at this point in the history
There is no jumbo_executable target atm, so split the cctest v8_executable
target into cctest and cctest_sources.

Bug: chromium:746958
Change-Id: Iec0956234d026039c4d29921170dd2f0955222ca
Reviewed-on: https://chromium-review.googlesource.com/680575
Reviewed-by: Jakob Kummerow <jkummerow@chromium.org>
Commit-Queue: Mostyn Bramley-Moore <mostynb@opera.com>
Cr-Commit-Position: refs/heads/master@{#48147}
  • Loading branch information
mostynb authored and Commit Bot committed Sep 25, 2017
1 parent 72484a6 commit dbe9457
Showing 1 changed file with 41 additions and 18 deletions.
59 changes: 41 additions & 18 deletions test/cctest/BUILD.gn
Expand Up @@ -6,6 +6,34 @@ import("../../gni/v8.gni")

v8_executable("cctest") {
testonly = true
deps = [
":cctest_sources",
]
configs = [
"../..:external_config",
"../..:internal_config_base",
]

ldflags = []

# TODO(machenbach): Translate from gyp.
#["OS=="aix"", {
# "ldflags": [ "-Wl,-bbigtoc" ],
#}],

# crbug.com/676417: Suppress symbol import warning from linker.
if (is_win && is_component_build) {
ldflags += [
"/ignore:4217",
"/ignore:4049",
]
remove_configs = [ "//build/config/win:default_incremental_linking" ]
configs += [ "//build/config/win:no_incremental_linking" ]
}
}

v8_source_set("cctest_sources") {
testonly = true

sources = [
"$target_gen_dir/resources.cc",
Expand Down Expand Up @@ -209,6 +237,17 @@ v8_executable("cctest") {
"wasm/wasm-run-utils.h",
]

if (use_jumbo_build) {
jumbo_excluded_sources = [
# TODO(mostynb@opera.com): figure out the jumbo issues with these source
# files, and include them in jumbo compilation units.
"interpreter/bytecode-expectations-printer.cc",
"interpreter/bytecode-expectations-printer.h",
"test-api.cc",
"test-api.h",
]
}

if (v8_current_cpu == "arm") {
sources += [ ### gcmole(arch:arm) ###
"test-assembler-arm.cc",
Expand Down Expand Up @@ -320,12 +359,7 @@ v8_executable("cctest") {
"../..:internal_config_base",
]

# TODO(machenbach): Translate from gyp.
#["OS=="aix"", {
# "ldflags": [ "-Wl,-bbigtoc" ],
#}],

deps = [
public_deps = [
":resources",
"../..:v8_initializers",
"../..:v8_libbase",
Expand All @@ -336,6 +370,7 @@ v8_executable("cctest") {
]

defines = []
deps = []

if (is_component_build) {
# cctest can't be built against a shared library, so we
Expand All @@ -353,18 +388,6 @@ v8_executable("cctest") {
}

cflags = []
ldflags = []

# crbug.com/676417: Suppress symbol import warning from linker.
if (is_win && is_component_build) {
ldflags += [
"/ignore:4217",
"/ignore:4049",
]
remove_configs = [ "//build/config/win:default_incremental_linking" ]
configs += [ "//build/config/win:no_incremental_linking" ]
}

if (v8_current_cpu == "ppc" || v8_current_cpu == "ppc64" ||
v8_current_cpu == "arm" || v8_current_cpu == "arm64" ||
v8_current_cpu == "s390" || v8_current_cpu == "s390x" ||
Expand Down

0 comments on commit dbe9457

Please sign in to comment.