Skip to content

Commit

Permalink
Rename local macro CHECK_RECEIVER -> CHECK_RECEIVER_OBJECT
Browse files Browse the repository at this point in the history
builtins_util.h declares a macro named CHECK_RECEIVER and in some
extreme jumbo build configurations, that macro will end up in the
same translation unit as runtime-dataview.cc

Bug: v8:7792
Change-Id: I6db865b6061afd6bf1c74b3a172485d68c749929
Reviewed-on: https://chromium-review.googlesource.com/1075052
Commit-Queue: Jakob Kummerow <jkummerow@chromium.org>
Reviewed-by: Jakob Kummerow <jkummerow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#53430}
  • Loading branch information
bratell-at-opera authored and Commit Bot committed May 29, 2018
1 parent edd6803 commit f95d7bc
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions src/runtime/runtime-dataview.cc
Expand Up @@ -230,7 +230,7 @@ MaybeHandle<Object> SetViewValue(Isolate* isolate, Handle<JSDataView> data_view,

} // namespace

#define CHECK_RECEIVER(method) \
#define CHECK_RECEIVER_OBJECT(method) \
Handle<Object> receiver = args.at<Object>(0); \
if (!receiver->IsJSDataView()) { \
THROW_NEW_ERROR_RETURN_FAILURE( \
Expand All @@ -244,7 +244,7 @@ MaybeHandle<Object> SetViewValue(Isolate* isolate, Handle<JSDataView> data_view,
#define DATA_VIEW_PROTOTYPE_GET(Type, type) \
RUNTIME_FUNCTION(Runtime_DataViewGet##Type) { \
HandleScope scope(isolate); \
CHECK_RECEIVER("DataView.prototype.get" #Type); \
CHECK_RECEIVER_OBJECT("DataView.prototype.get" #Type); \
Handle<Object> byte_offset = args.at<Object>(1); \
Handle<Object> is_little_endian = args.at<Object>(2); \
Handle<Object> result; \
Expand All @@ -271,7 +271,7 @@ DATA_VIEW_PROTOTYPE_GET(BigUint64, uint64_t)
#define DATA_VIEW_PROTOTYPE_SET(Type, type) \
RUNTIME_FUNCTION(Runtime_DataViewSet##Type) { \
HandleScope scope(isolate); \
CHECK_RECEIVER("DataView.prototype.set" #Type); \
CHECK_RECEIVER_OBJECT("DataView.prototype.set" #Type); \
Handle<Object> byte_offset = args.at<Object>(1); \
Handle<Object> value = args.at<Object>(2); \
Handle<Object> is_little_endian = args.at<Object>(3); \
Expand All @@ -296,6 +296,6 @@ DATA_VIEW_PROTOTYPE_SET(BigInt64, int64_t)
DATA_VIEW_PROTOTYPE_SET(BigUint64, uint64_t)
#undef DATA_VIEW_PROTOTYPE_SET

#undef CHECK_RECEIVER
#undef CHECK_RECEIVER_OBJECT
} // namespace internal
} // namespace v8

0 comments on commit f95d7bc

Please sign in to comment.