Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Undefined name: 'Error' use 'Exception' instead #44

Closed
wants to merge 1 commit into from
Closed

Undefined name: 'Error' use 'Exception' instead #44

wants to merge 1 commit into from

Conversation

cclauss
Copy link

@cclauss cclauss commented Aug 24, 2020

@jakobkummerow https://docs.python.org/3/library/exceptions.html#Exception is the base class for most Python errors and Error is undefined in this context so NameError will be raised instead of the desired exception message.

@cclauss
Undefined name: 'Error' use 'Excception' instead
9e01fad 
@ jakobkummerow https://docs.python.org/3/library/exceptions.html#Exception is the base class for most Python errors and `Error` is undefined in this context so NameError will be raised instead of the desired exception message.
@cclauss cclauss changed the title Undefined name: 'Error' use 'Excception' instead Undefined name: 'Error' use 'Exception' instead Aug 24, 2020
ceejatec pushed a commit to couchbasedeps/v8-mirror that referenced this pull request Sep 24, 2020
Version 7.8.279.22
b0b10d3 
TBR=v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com

Change-Id: Iba323fefeb9f4d7c62b5de4521b75faf74740e16
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1899251
Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/7.8@{v8#44}
Cr-Branched-From: 73694fd-refs/heads/7.8.279@{#1}
Cr-Branched-From: 2314928-refs/heads/master@{#63555}
ceejatec pushed a commit to couchbasedeps/v8-mirror that referenced this pull request Sep 24, 2020
Version 7.9.317.22
7ddb634 
TBR=v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com

Change-Id: I9258332b859d3c66fb06487f11991802aed3e9db
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1912945
Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/7.9@{v8#44}
Cr-Branched-From: be181e2-refs/heads/7.9.317@{#1}
Cr-Branched-From: 0d7889d-refs/heads/master@{#64307}
ceejatec pushed a commit to couchbasedeps/v8-mirror that referenced this pull request Sep 24, 2020
@GeorgNeis
Merged: [modules] Fix bug in instantiation failure handling
1864ea9 
Revision: 6239ec1

BUG=chromium:1050164
NOTRY=true
NOPRESUBMIT=true
NOTREECHECKS=true
TBR=hablich@chromium.org

Change-Id: I99c666c2fed8a7528a5ab4a070dda78cff34f0b5
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2056860
Reviewed-by: Georg Neis <neis@chromium.org>
Commit-Queue: Georg Neis <neis@chromium.org>
Cr-Commit-Position: refs/branch-heads/8.0@{v8#44}
Cr-Branched-From: 69827db-refs/heads/8.0.426@{v8#2}
Cr-Branched-From: 2fe1552-refs/heads/master@{#65318}
ceejatec pushed a commit to couchbasedeps/v8-mirror that referenced this pull request Sep 24, 2020
Version 8.1.307.21
9b18304 
TBR=v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com

Change-Id: Iee323c2f23ef0d5d59c515b817670fafdb5cceb5
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2094659
Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/8.1@{v8#44}
Cr-Branched-From: a4dcd39-refs/heads/8.1.307@{#1}
Cr-Branched-From: f22c213-refs/heads/master@{#66031}
ceejatec pushed a commit to couchbasedeps/v8-mirror that referenced this pull request Sep 24, 2020
@almuthanna-athamina
Merged: [test] Work around Android linker warning in test output
2147faa 
Revision: 07e7102

BUG=chromium:1099623
NOTRY=true
NOPRESUBMIT=true
NOTREECHECKS=true
R=machenbach@chromium.org

Change-Id: I5cabff11455b16042f67b48aa8ca6809e5015195
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2410189
Reviewed-by: Michael Achenbach <machenbach@chromium.org>
Commit-Queue: Almothana Athamneh <almuthanna@chromium.org>
Cr-Commit-Position: refs/branch-heads/8.5@{v8#44}
Cr-Branched-From: a7f8bc4-refs/heads/8.5.210@{#1}
Cr-Branched-From: dd58472-refs/heads/master@{#68510}
ceejatec pushed a commit to couchbasedeps/v8-mirror that referenced this pull request Sep 24, 2020
Whitespace to trigger builders
bbabf81 
TBR: clemensb@chromium.org
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Change-Id: I17095b9edc4b222ffd5cc29ff955e14042b34884
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2330018
Reviewed-by: Liviu Rau <liviurau@chromium.org>
Commit-Queue: Liviu Rau <liviurau@chromium.org>
Cr-Commit-Position: refs/branch-heads/8.4@{v8#44}
Cr-Branched-From: 88ed2e3-refs/heads/8.4.371@{#1}
Cr-Branched-From: 35f88bf-refs/heads/master@{#67773}
@cclauss
Copy link
Author

cclauss commented Apr 17, 2021 •
edited

@DeeDeeG your review, please.

Also, urllib2 was removed in Python 3.

@surma
Copy link

surma commented Apr 17, 2021

This is just a mirror

@surma surma closed this Apr 17, 2021
Kwizatz pushed a commit to AeonGames/v8 that referenced this pull request Jul 25, 2021
Version 9.1.269.22
f4633df 
TBR=v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com

Change-Id: I79e179fce92c8cc27d3ea3590a1d71061ed2e8d7
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2871400
Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/9.1@{v8#44}
Cr-Branched-From: 0e4ac64-refs/heads/9.1.269@{#1}
Cr-Branched-From: f565e72-refs/heads/master@{#73847}
cb-robot pushed a commit to couchbasedeps/v8-mirror that referenced this pull request Aug 24, 2022
@backes
Merged: [liftoff][arm64] Fix address computation for trap handling
c7faf5d 
This refactors the {GetMemOp} function once again:
Instead of computing (mem_start + (offset_reg + offset_imm)), do compute
((mem_start + offset_imm) + offset_reg). This avoids an overflow in
(offset_reg + offset_imm) when using 32-bit computations, which hides
OOB memory accesses when relying on the trap handler.

As a nice side-effect, this change makes the whole method a lot nicer to
read.

We also need to change {StoreTaggedPointer} now, which was relying on the
inner working of {GetMemOp}. The new version makes the semantics more
transparent at the cost of repeating some logic from (the previous version
of) {GetMemOp}.

TBR=jkummerow@chromium.org

(cherry picked from commit c8d60d7)

Bug: chromium:1227465, chromium:1224882
Change-Id: I3ed1c42cebab6d626a1a6aec8e874b868c077526
No-Try: true
No-Tree-Checks: true
No-Presubmit: true
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3059695
Reviewed-by: Jakob Kummerow <jkummerow@chromium.org>
Commit-Queue: Clemens Backes <clemensb@chromium.org>
Cr-Commit-Position: refs/branch-heads/9.2@{v8#44}
Cr-Branched-From: 5123834-refs/heads/9.2.230@{#1}
Cr-Branched-From: 587a04f-refs/heads/master@{#74656}
cb-robot pushed a commit to couchbasedeps/v8-mirror that referenced this pull request Aug 24, 2022
Version 8.9.255.21
c655e31 
TBR=v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com

Change-Id: I548b682a49cf1e8e4a57559daad866689f694a7b
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2781747
Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/8.9@{v8#44}
Cr-Branched-From: 16b9bbb-refs/heads/8.9.255@{#1}
Cr-Branched-From: d16a2a6-refs/heads/master@{#72039}
cb-robot pushed a commit to couchbasedeps/v8-mirror that referenced this pull request Aug 24, 2022
@gahaas
Merged: [wasm] Fix partial deserialization for lazy compilation
6bd016b 
The function index encoded into the serialized module is already offset
by num_imported_functions. For lazy compilation, however, we added the
number of imported functions another time, which was incorrect.


(cherry picked from commit 9380e55)

No-Try: true
No-Presubmit: true
No-Tree-Checks: true
Change-Id: Idcf478c05fd070d99cba0a1a1823cf4e57aa1dc3
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3207001
Commit-Queue: Adam Klein <adamk@chromium.org>
Reviewed-by: Andreas Haas <ahaas@chromium.org>
Cr-Commit-Position: refs/branch-heads/9.4@{v8#44}
Cr-Branched-From: 3b51863-refs/heads/9.4.146@{#1}
Cr-Branched-From: 2890419-refs/heads/master@{#76233}
cb-robot pushed a commit to couchbasedeps/v8-mirror that referenced this pull request Aug 24, 2022
@marjakh
Merged: [super ic] Fix receiver vs lookup start object confusion rela…
a30807d 
…ted to module exports

Revision: e4dba97

BUG=chromium:1260577
NOTRY=true
NOPRESUBMIT=true
NOTREECHECKS=true
R=ishell@chromium.org

Change-Id: I65dd7fef6b2612d204a025e053bdd96310d622bb
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3236721
Reviewed-by: Igor Sheludko <ishell@chromium.org>
Commit-Queue: Marja Hölttä <marja@chromium.org>
Cr-Commit-Position: refs/branch-heads/9.5@{v8#44}
Cr-Branched-From: 4a03d61-refs/heads/9.5.172@{#1}
Cr-Branched-From: 9a60704-refs/heads/main@{#76741}
cb-robot pushed a commit to couchbasedeps/v8-mirror that referenced this pull request Aug 24, 2022
@LeszekSwirski @isheludko
Merged: [map] Try to in-place transition during map update
3ba21a1 
When searching for a target map during map update, attempt to
update field representations in-place to the more general
representation, where possible.

Bug: chromium:1143772
No-Try: true
No-Presubmit: true
No-Tree-Checks: true

TBR=leszeks@chromium.org, fgm@chromium.org
(cherry picked from commit 8e3ae62)

Change-Id: I659890c2f08c14d1cf94242fb875c19837df2dbb
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2509599
Reviewed-by: Francis McCabe <fgm@chromium.org>
Reviewed-by: Michael Hablich <hablich@chromium.org>
Reviewed-by: Bill Budge <bbudge@chromium.org>
Reviewed-by: Igor Sheludko <ishell@chromium.org>
Cr-Commit-Position: refs/branch-heads/8.6@{v8#44}
Cr-Branched-From: a64aed2-refs/heads/8.6.395@{#1}
Cr-Branched-From: a626bc0-refs/heads/master@{#69472}
cb-robot pushed a commit to couchbasedeps/v8-mirror that referenced this pull request Aug 24, 2022
@hannespayer
Merged: cppgc: Fix marking of ephemerons with keys in construction
7d79acb 
Revision: 4feccb9

BUG=chromium:1259587
NOTRY=true
NOPRESUBMIT=true
NOTREECHECKS=true
R=verwaest@chromium.org

Change-Id: I941058dedebdde5c2d4567a57a953a2ce212e4d3
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3350459
Reviewed-by: Toon Verwaest <verwaest@chromium.org>
Commit-Queue: Hannes Payer <hpayer@chromium.org>
Cr-Commit-Position: refs/branch-heads/9.6@{v8#44}
Cr-Branched-From: 0b7bda0-refs/heads/9.6.180@{#1}
Cr-Branched-From: 41a5a24-refs/heads/main@{#77244}
cb-robot pushed a commit to couchbasedeps/v8-mirror that referenced this pull request Aug 24, 2022
Version 9.0.257.22
748101d 
TBR=v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com

Change-Id: I51026440e6c657a1d015f9bb12fc1348386c6279
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2845318
Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/9.0@{v8#44}
Cr-Branched-From: bd0108b-refs/heads/9.0.257@{#1}
Cr-Branched-From: 349bcc6-refs/heads/master@{#73001}
cb-robot pushed a commit to couchbasedeps/v8-mirror that referenced this pull request Aug 24, 2022
Version 8.7.220.22
5f1db4f 
TBR=v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com

Change-Id: I60bf5913cfcff78dd04bef4e03dc71d225946e7a
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2528896
Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/8.7@{v8#44}
Cr-Branched-From: 0d81cd7-refs/heads/8.7.220@{#1}
Cr-Branched-From: 942c2ef-refs/heads/master@{#70196}
patrik-lengweiler pushed a commit to hexagon-geo-surv/v8 that referenced this pull request May 31, 2023
Version 10.2.154.23
4a4c2bd 
Change-Id: Ie5fac1cbf8a8009ec4152ad5806cb6cc4c646b42
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4101300
Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/10.2@{v8#44}
Cr-Branched-From: 374091f-refs/heads/10.2.154@{#1}
Cr-Branched-From: f0c353f-refs/heads/main@{#79976}
patrik-lengweiler pushed a commit to hexagon-geo-surv/v8 that referenced this pull request May 31, 2023
Version 11.2.214.20
8e4a71a 
Change-Id: Ia4fe97ed9dc4e33c542a0bc3607fb2639525016c
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4507153
Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/11.2@{v8#44}
Cr-Branched-From: 755511a-refs/heads/11.2.214@{#1}
Cr-Branched-From: e6b1cce-refs/heads/main@{#86014}
patrik-lengweiler pushed a commit to hexagon-geo-surv/v8 that referenced this pull request May 31, 2023
Version 10.6.194.22
9427915 
Change-Id: I216da8845635669fb415e28bb07a4761d98390e8
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3982419
Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/10.6@{v8#44}
Cr-Branched-From: 41bc743-refs/heads/10.6.194@{#1}
Cr-Branched-From: d5f29b9-refs/heads/main@{#82548}
patrik-lengweiler pushed a commit to hexagon-geo-surv/v8 that referenced this pull request May 31, 2023
@verwaest
Merged: [parser] Reset the calls_eval flag after arrow head
4ace4b0 
Otherwise it's propagated to the parent

Bug: chromium:1394973
(cherry picked from commit e1e0890)

Change-Id: I723e7b289b9aa3016cc466bd349898d7c7e0ffe9
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4108349
Reviewed-by: Toon Verwaest <verwaest@chromium.org>
Commit-Queue: Igor Sheludko <ishell@chromium.org>
Cr-Commit-Position: refs/branch-heads/10.8@{v8#44}
Cr-Branched-From: f1bc03f-refs/heads/10.8.168@{#1}
Cr-Branched-From: 237de89-refs/heads/main@{#83672}
patrik-lengweiler pushed a commit to hexagon-geo-surv/v8 that referenced this pull request May 31, 2023
Version 10.4.132.24
0bd243e 
Change-Id: I26236d2c4d2d44e7666196f8dc50e171648ba60e
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3880188
Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/10.4@{v8#44}
Cr-Branched-From: b1413ed-refs/heads/10.4.132@{#1}
Cr-Branched-From: 9d0a093-refs/heads/main@{#80972}
patrik-lengweiler pushed a commit to hexagon-geo-surv/v8 that referenced this pull request Jun 10, 2023
Version 11.4.183.22
3754be1 
Change-Id: If20edaecc533feac51cb7db1998132acc2763018
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4605051
Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/11.4@{v8#44}
Cr-Branched-From: 8a8a1e7-refs/heads/11.4.183@{#1}
Cr-Branched-From: 5483d8e-refs/heads/main@{#87241}
reposynch bot pushed a commit to hexagon-geo-surv/v8 that referenced this pull request Aug 6, 2023
Version 11.5.150.22
e6cc87a 
Change-Id: Iba6edc626d535d6da9da425582812899815552a2
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4730656
Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/11.5@{v8#44}
Cr-Branched-From: 0c4044b-refs/heads/11.5.150@{#1}
Cr-Branched-From: b71d303-refs/heads/main@{#87781}
reposynch bot pushed a commit to hexagon-geo-surv/v8 that referenced this pull request Jan 14, 2024
Version 12.1.285.22
8b2b1e4 
Change-Id: Ia1e53286fc73b298fbf85b4c5eb5d388ba9126dd
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5189145
Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/12.1@{v8#44}
Cr-Branched-From: b74ef6f-refs/heads/12.1.285@{#1}
Cr-Branched-From: 32857fb-refs/heads/main@{#91313}
hubot pushed a commit that referenced this pull request Mar 11, 2024
@syg
Merged: [parser] Fix home object proxy to work off-thread
3eb2942 
Because the home object has special scope lookup rules due to class
heritage position, VariableProxies of the home object are currently
directly created on the correct scope during parsing. However, during
off-thread parsing the main thread is parked, and the correct scope
may try to dereference a main-thread Handle.

This CL moves the logic into ResolveVariable instead, which happens
during postprocessing, with the main thread unparked.

Fixed: chromium:327740539

(cherry picked from commit 8f477f9)

Change-Id: I16805ad35f5d70d1acadaf1f5440dfc159dbfa6c
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5363634
Reviewed-by: Deepti Gandluri <gdeepti@chromium.org>
Commit-Queue: Shu-yu Guo <syg@chromium.org>
Cr-Commit-Position: refs/branch-heads/12.2@{#44}
Cr-Branched-From: 6eb5a96-refs/heads/12.2.281@{#1}
Cr-Branched-From: 44cf56d-refs/heads/main@{#91934}
hubot pushed a commit that referenced this pull request Apr 10, 2024
@manoskouk
[M120-LTS][wasm] Check for type-definition count limit
8856a2a 
(cherry picked from commit b852ad7)

(cherry picked from commit 75fe5a5)

Bug: chromium:330575498
Change-Id: I395f0ed6d823b7d1e139da6551486e3627d65724
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5378419
Commit-Queue: Jakob Kummerow <jkummerow@chromium.org>
Auto-Submit: Manos Koukoutos <manoskouk@chromium.org>
Cr-Original-Original-Commit-Position: refs/heads/main@{#92941}
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5380190
Commit-Queue: Adam Klein <adamk@chromium.org>
Cr-Original-Commit-Position: refs/branch-heads/12.2@{#50}
Cr-Original-Branched-From: 6eb5a96-refs/heads/12.2.281@{#1}
Cr-Original-Branched-From: 44cf56d-refs/heads/main@{#91934}
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5394499
Commit-Queue: Zakhar Voit <voit@google.com>
Reviewed-by: Victor Gabriel Savu <vsavu@google.com>
Reviewed-by: Manos Koukoutos <manoskouk@chromium.org>
Cr-Commit-Position: refs/branch-heads/12.0@{#44}
Cr-Branched-From: ed7b4ca-refs/heads/12.0.267@{#1}
Cr-Branched-From: 210e75b-refs/heads/main@{#90651}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@cclauss @surma