Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

todo: add Settings, slider for out size, use custom outpath #11

Closed
GeorgLegato opened this issue Apr 15, 2023 · 11 comments
Closed

todo: add Settings, slider for out size, use custom outpath #11

GeorgLegato opened this issue Apr 15, 2023 · 11 comments
Assignees

Comments

@GeorgLegato
Copy link
Collaborator

GeorgLegato commented Apr 15, 2023

Assigning to me. to avoid races or concurrent implementations

GeorgLegato added a commit to GeorgLegato/infinite-zoom-automatic1111-webui that referenced this issue Apr 15, 2023
@v8hid
Copy link
Owner

v8hid commented Apr 15, 2023

Hello @GeorgLegato, I'm interested in learning more about the features you're looking to add to the project. I have a list of potential features and would welcome your input. If you're interested in contributing, I can add you to the project.

In order to communicate more directly, could you please let me know how I can reach you? Thank you!

@GeorgLegato
Copy link
Collaborator Author

nothing special. just to extend stuff, like
ratio support, not only squared
I havent yet understood completely how the process is, so i need a bit to investigate
put me to your project, communication here is fine

@GeorgLegato
Copy link
Collaborator Author

One feature for 360 panorama movies is to end the video on the last frame, forevery. So tha zoom in/out of the movie can be still viewed interactively in the 360 sphere.

@GeorgLegato
Copy link
Collaborator Author

@v8hid
Copy link
Owner

v8hid commented Apr 15, 2023

There are a few issues that we should consider:

  1. The program is currently designed to process images with aspect ratios of 1:1. We should verify if the program should be updated to handle other aspect ratios as well.

  2. If you want to change the resolution, you will need to modify the mask_with variable accordingly.

  3. If we want to add a button for sending images to another extension, we should check if the user has that extension installed before showing the button.

@GeorgLegato
Copy link
Collaborator Author

  1. yes, thats why first the slider tweaks both x and y
  2. i ll check
    3 the sendto button is already in my extension. so my extension is installed and adds this button.

@GeorgLegato
Copy link
Collaborator Author

  1. howto calculate mask_width? just output_size/2?

@v8hid
Copy link
Owner

v8hid commented Apr 15, 2023

  1. howto calculate mask_width? just output_size/2?

it should be less than image_width / 2, the optimal result might be image_width / 4

v8hid added a commit that referenced this issue Apr 15, 2023
fix issue #11, 'infinite-zoom' settings added to webui setting including 'select size' and 'output folder'
@GeorgLegato
Copy link
Collaborator Author

video size is always 512, because the size of frames is not used for writing, see video.py line 17 "w,h" unsused

@v8hid
Copy link
Owner

v8hid commented Apr 15, 2023

video size is always 512, because the size of frames is not used for writing, see video.py line 17 "w,h" unsused

Right thank you, I need to refactor the code soon :))

@GeorgLegato
Copy link
Collaborator Author

video size is always 512, because the size of frames is not used for writing, see video.py line 17 "w,h" unsused

Right thank you, I need to refactor the code soon :))

I have disabled the w,h variables. the writer is not to be set explicetely, driven by input frame size and that block size

@v8hid v8hid closed this as completed in 3a02a1e Apr 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants