Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for multiple generations per run #27

Merged
merged 2 commits into from
Apr 18, 2023
Merged

Conversation

deklesen
Copy link
Contributor

This PR implements multiple generations per run.

It's admittedly pretty hacky (only the last generated video is shown in the GUI), but might still be worth to merge.

@GeorgLegato
Copy link
Collaborator

this is the point I meant we should go for doing this as SCRIPT, means a script in the img2img section.
when we add batchcount, select model, size, denoise, etc. we rebuild the img2img tab, right?

@v8hid
Copy link
Owner

v8hid commented Apr 17, 2023

Hi @deklesen, maybe it's better to ignore the video component and go with HTML5 video tag for showing the output.

@v8hid
Copy link
Owner

v8hid commented Apr 17, 2023

@GeorgLegato The Img2Img page is already too full of parameters, We want to keep the extension more organized and clean because people would have a better experience in this way.
I'm planning to remove a few redundant parameters such as Denoising strength, Inpaint Full Resolution, and padding. While these parameters can be helpful in the context of inpainting, they aren't necessary for our purposes and can add unnecessary confusion for users.

@GeorgLegato
Copy link
Collaborator

and here is an extension doing it via script
https://github.com/avantcontra/sd-webui-bug-infinite

@deklesen
Copy link
Contributor Author

@GeorgLegato I like the current way, i.e. as a seperate tab, more.

@deklesen
Copy link
Contributor Author

Hi @deklesen, maybe it's better to ignore the video component and go with HTML5 video tag for showing the output.

Sorry, I won't implement this PR in a better way, feel free to close the PR if its too hacky as-is.

@deklesen deklesen closed this Apr 17, 2023
@deklesen deklesen deleted the multiple-runs branch April 17, 2023 21:03
@v8hid
Copy link
Owner

v8hid commented Apr 17, 2023

Hello @deklesen! I noticed that you recently closed your pull request. I apologize for the delay in reviewing it, and I want to let you know that I value your contribution. I was planning to review it in action before merging it, but if you decided to close it for other reasons, please let me know. Thank you for your interest in contributing to the project!

@deklesen deklesen restored the multiple-runs branch April 17, 2023 21:46
@deklesen
Copy link
Contributor Author

Hi v8hid, thanks, i think it got auto-deleted since i deleted the branch of my fork...

@deklesen deklesen reopened this Apr 17, 2023
@GeorgLegato
Copy link
Collaborator

hehe, yeah keep your work, we will get this into consideration.
multirun makes sence, this the gallery is pretty useless, it always display THE ONE render

Moving `Batch Count` to bottom of setting

Signed-off-by: vahid khroasani <62482657+v8hid@users.noreply.github.com>
@v8hid v8hid merged commit dbc8b13 into v8hid:main Apr 18, 2023
@deklesen deklesen deleted the multiple-runs branch April 18, 2023 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants