fix segmentation fault bug in fft.ifft (#557)

v923z · Nov 7, 2022 · 25a825e · 25a825e
1 parent 155dad9
commit 25a825e
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 4 deletions.
diff --git a/code/numpy/fft/fft_tools.c b/code/numpy/fft/fft_tools.c
@@ -118,9 +118,9 @@ mp_obj_t fft_fft_ifft_spectrogram(mp_obj_t data_in, uint8_t type) {
 
     if(in->dtype == NDARRAY_COMPLEX) {
         uint8_t sz = 2 * sizeof(mp_float_t);
-        uint8_t *data_ = (uint8_t *)out->array;
         for(size_t i = 0; i < len; i++) {
-            memcpy(data_, array, sz);
+            memcpy(data, array, sz);
+            data += 2;
             array += in->strides[ULAB_MAX_DIMS - 1];
         }
     } else {
@@ -149,7 +149,7 @@ mp_obj_t fft_fft_ifft_spectrogram(mp_obj_t data_in, uint8_t type) {
     } else { // inverse transform
         fft_kernel_complex(data, len, -1);
         // TODO: numpy accepts the norm keyword argument
-        for(size_t i = 0; i < len; i++) {
+        for(size_t i = 0; i < 2 * len; i++) {
             *data++ /= len;
         }
     }

diff --git a/code/ulab.c b/code/ulab.c
@@ -33,7 +33,7 @@
 #include "user/user.h"
 #include "utils/utils.h"
 
-#define ULAB_VERSION 6.0.0
+#define ULAB_VERSION 6.0.1
 #define xstr(s) str(s)
 #define str(s) #s
 

diff --git a/docs/ulab-change-log.md b/docs/ulab-change-log.md
@@ -1,3 +1,9 @@
+Sat, 5 Nov 2022
+
+version 6.0.1
+
+    fix fft.ifft
+
 Wed, 21 Sep 2022
 
 version 6.0.0