-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix -Wunused-variable diagnostic when !ULAB_SUPPORTS_COMPLEX #631
Conversation
`o_in` is only used in the SUPPORTS_COMPLEX case, so the variable definition needs to be moved accordingly.
@jepler Indeed, many thanks for bringing this up! Could you, please, change the version number to 6.3.4, and then merge this? |
code/ulab.c
Outdated
@@ -33,7 +33,7 @@ | |||
#include "user/user.h" | |||
#include "utils/utils.h" | |||
|
|||
#define ULAB_VERSION 6.3.2 | |||
#define ULAB_VERSION 6.3.3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be set to 6.3.4.
docs/ulab-change-log.md
Outdated
@@ -1,5 +1,17 @@ | |||
Fri, 12 May 2023 | |||
|
|||
version 6.3.3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
6.3.3 brings in an improvement on polyval
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done!
@jepler Many thanks, Jeff! I've merged this. |
o_in
is only used in the SUPPORTS_COMPLEX case, so the variable definition needs to be moved accordingly.