Drop certain CircuitPython workarounds that are no longer needed #647
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
jepler
commented
Sep 22, 2023
jepler
commented
- ndarray_set_value: in CircuitPython 9
- mp_obj_slice_indices: ditto
- Use modern MP_REGISTER_MODULE calls: ditto
- use MP_OBJ_SENTINEL to forward to locals dict (was never necessary?)
* ndarray_set_value: in CircuitPython 9 * mp_obj_slice_indices: ditto * Use modern MP_REGISTER_MODULE calls: ditto * use MP_OBJ_SENTINEL to forward to locals dict (was never necessary?)
|
This will maybe be suitable to merge once CP's merge of 1.20 is ready. The CP builds are expected to error for now! |
jepler
added a commit
to dhalbert/circuitpython
that referenced
this pull request
Sep 22, 2023
this lets ulab drop several workarounds for circuitpython lagging MP yay! (v923z/micropython-ulab#647)
|
@jepler It's really up to you. You should just merge this, whenever you see fit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.