Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix the np.delete bug #653

Merged
merged 4 commits into from
Dec 25, 2023
Merged

fix the np.delete bug #653

merged 4 commits into from
Dec 25, 2023

Conversation

hiltay
Copy link
Contributor

@hiltay hiltay commented Dec 25, 2023

fix the np.delete bug in simple way.
now,if the second positional argument is empty list [],return the original array instead.

@v923z
Copy link
Owner

v923z commented Dec 25, 2023

Thanks! Could you, please, increment the version number here

#define ULAB_VERSION 6.4.2
, and add an entry here https://github.com/v923z/micropython-ulab/blob/master/docs/ulab-change-log.md?

Also, it would be great, if this error was addressed in https://github.com/v923z/micropython-ulab/blob/master/tests/2d/numpy/delete.py.

@v923z
Copy link
Owner

v923z commented Dec 25, 2023

@hiltay
Copy link
Contributor Author

hiltay commented Dec 25, 2023

I'm very willing to contribute and test:)
anything else to add?

@v923z
Copy link
Owner

v923z commented Dec 25, 2023

I'm very willing to contribute and test:) anything else to add?

I think this is complete now, and as soon as the workflow finishes, I merge the PR. Many thanks for contributing!

@v923z v923z merged commit 7a93706 into v923z:master Dec 25, 2023
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants