Skip to content

Commit

Permalink
Better variable name
Browse files Browse the repository at this point in the history
  • Loading branch information
vEnhance committed Sep 1, 2023
1 parent d81ad8a commit 4ec0f2d
Showing 1 changed file with 8 additions and 6 deletions.
14 changes: 8 additions & 6 deletions rpg/views.py
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,8 @@

logger = logging.getLogger(__name__)

RUBY_PALACE_DIAMOND_VALUE = 4


@login_required
def stats(request: AuthHttpRequest, student_pk: int) -> HttpResponse:
Expand Down Expand Up @@ -291,9 +293,6 @@ def get_success_url(self):
return reverse("palace-list", args=(self.student.pk,))


n = 4


class DiamondUpdate(
LoginRequiredMixin,
UpdateView[Achievement, BaseModelForm[Achievement]],
Expand All @@ -320,7 +319,7 @@ def get_object(self, *args: Any, **kwargs: Any) -> Achievement:
achievement.code = "".join(
random.choice("0123456789abcdef") for _ in range(24)
)
achievement.diamonds = n
achievement.diamonds = RUBY_PALACE_DIAMOND_VALUE
achievement.name = student.name
achievement.save()

Expand All @@ -332,9 +331,12 @@ def get_object(self, *args: Any, **kwargs: Any) -> Achievement:

def form_valid(self, form: BaseModelForm[Achievement]):
assert_maxed_out_level_info(self.student)
form.instance.diamonds = n
form.instance.diamonds = RUBY_PALACE_DIAMOND_VALUE
form.instance.creator = self.student.user
messages.success(self.request, f"Successfully forged diamond worth {n}♦.")
messages.success(
self.request,
f"Successfully forged diamond worth {form.instance.diamonds}♦.",
)
return super().form_valid(form)

def get_context_data(self, **kwargs: Any) -> dict[str, Any]:
Expand Down

0 comments on commit 4ec0f2d

Please sign in to comment.