Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework leg math #39

Open
va3wam opened this issue Nov 3, 2021 · 3 comments
Open

Rework leg math #39

va3wam opened this issue Nov 3, 2021 · 3 comments
Assignees
Labels
type: enhancement Tweak the way an exiting feature behaves.

Comments

@va3wam
Copy link
Owner

va3wam commented Nov 3, 2021

Switch the X Y and Z axis currently used by the leg math to the new Robot wide coordinate system per issue 38.

@va3wam va3wam added this to Needs triage in Write embedded code via automation Nov 3, 2021
@theAgingApprentice theAgingApprentice moved this from Needs triage to High priority in Write embedded code Nov 3, 2021
@nerdoug
Copy link
Collaborator

nerdoug commented Dec 2, 2021

The mathematical complexity of using global coordinates in the leg math is prohibitive. Better (and feasible) to use a local coordinate system that aligns with the orientation of the leg. Supporting this is a routine that converts global coordinates to the local coordinates of a specific leg. Using similar axis names for local and global coordinates can be confusing, so this task will be implemented as reworking the leg math, comments, documentation and variable names to use local axes p, q and r consistently for all legs.

@nerdoug nerdoug closed this as completed Dec 2, 2021
Write embedded code automation moved this from High priority to Closed Dec 2, 2021
@nerdoug nerdoug reopened this Dec 2, 2021
Write embedded code automation moved this from Closed to Needs triage Dec 2, 2021
@nerdoug
Copy link
Collaborator

nerdoug commented Dec 2, 2021

oops. "close with comment" did more closing than I intended

@theAgingApprentice theAgingApprentice moved this from Needs triage to Low priority in Write embedded code Dec 16, 2021
@theAgingApprentice theAgingApprentice added the type: enhancement Tweak the way an exiting feature behaves. label Apr 17, 2022
@theAgingApprentice
Copy link
Collaborator

Will be done as part of the reworking of the leg math that will be needed after we get the new chassis.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement Tweak the way an exiting feature behaves.
Projects
Development

No branches or pull requests

3 participants