Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ignore_regexps doesnt match against whole message, only subject #115

Closed
rasjani opened this issue Apr 30, 2019 · 0 comments
Closed

ignore_regexps doesnt match against whole message, only subject #115

rasjani opened this issue Apr 30, 2019 · 0 comments

Comments

@rasjani
Copy link

rasjani commented Apr 30, 2019

Documentation in the reference config file says this:

## Any commit having its full commit message matching any regexp listed here
## will be ignored and won't be reported in the changelog.

However: https://github.com/vaab/gitchangelog/blob/master/src/gitchangelog/gitchangelog.py#L1592

Looks like that the ignored regexps are only matched against commit.subject.

Personally i prefere to keep the commit subject line under 72 characters and thus, sometimes im forced to put, say, !minor into the first actual line of the commit message (or just last). And then, these lines will show up in the changelog.

rasjani pushed a commit to rasjani/gitchangelog that referenced this issue Apr 30, 2019
@rasjani rasjani closed this as completed Oct 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant