Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add the header component after a refresh event #36

Merged
merged 2 commits into from
Jan 12, 2024

Conversation

sujoykd
Copy link
Contributor

@sujoykd sujoykd commented Jan 11, 2024

When the view is marked @PreserveOnRefresh, the column header component is not attached on refresh. The component still contains all the information, but its not set to the header.

This PR attempts to fix that.

@sujoykd sujoykd requested a review from paodb January 12, 2024 08:46
Copy link
Collaborator

@paodb paodb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sujoykd sujoykd merged commit e3ae6be into main Jan 12, 2024
1 check failed
@sujoykd sujoykd deleted the fix/preserve-on-refresh branch January 12, 2024 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants