With styling #17
Merged
With styling #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This implements the UX requirements listed in https://docs.google.com/document/d/1xftbmiAw491k0uag6lJi46B7slidXfmvOMbOgKm3G8U: - accessing any view requires logging in - accessing any endpoint requires logging in - deep links work even if logging in is required - expired sessions are re-established without loosing the app state The DX needs improvement. See the TODOs in the code.
This allows importing LitElement css literals from .css files and using them directly. For example, styles for the `login-view` component are imported from `login-view.css`: ```ts import styles from "./login-view.css"; @CustomElement('login-view') export class LoginView extends LitElement { static styles = styles; } ``` instead of including them inline in the component code: ```ts @CustomElement('login-view') export class LoginView extends LitElement { static styles = css` [styles here] `; } ``` NOTE: it requires a custom Webpack loader to avoid wrapping the imported CSS string into LitElement's `unsafeCSS` in the user code. Loader makes this wrapping automatic and invisible. Ideally, the loader should be released by Vaadin to npm, and used in the generated webpack config file by default.
- elevate the `src/views` folder up to `views` and rename it to `components` - create a separate folder for each component (to keep .css file next to the .ts file in the same folder) - gather should-not-be-needed and should-be-in-the-framework code inside a `utils` folder This brings the project structure closer to what the starter wizard generates.
Conflicts: frontend/components/contact-form/contact-form.ts frontend/connect-client.ts frontend/index.ts frontend/src/views/contact-form.ts
Haprog
commented
Aug 7, 2020
`lit-css-loader` is now used by default (in Flow) so we can remove customizations from webpack config. Uses default contents for webpack.config.js now. See vaadin/flow#8843
|
For making the review easier, I think it should be enough if someone else reviews only my changes to this branch, which is basically these 5 last commits since I've reviewed the older stuff. And the current |
platosha
approved these changes
Aug 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8