fix: login form was disabled after 2nd failed login #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On submit the `vaadin-login-form` sets `error` to `false` and `disabled` to `true`. Then the `disabled` status is removed only if `error` is set to `true` (via observer `_errorChanged(error)`). The issue was that Lit property bindings are one way so when login form sets its internal error status to false, our `login-view` still has `error` `true` (after first login failure) and when we try login for the second time then `this.error = result.error;` doesn't do anything because `this.error` is already `true` (in our view), so it doesn't change and it doesn't trigger the propagation of `error` `true` into login form component. Fixes #21
haijian-vaadin
approved these changes
Oct 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On submit the
vaadin-login-formsetserrortofalseanddisabledtotrue. Then thedisabledstatus is removed only iferroris set totrue(via observer_errorChanged(error)).The issue was that Lit property bindings are one way so when login form sets its internal error status to false, our
login-viewstill haserrortrue(after first login failure) and when we try login for the second time thenthis.error = result.error;doesn't do anything becausethis.erroris alreadytrue(in our view), so it doesn't change and it doesn't trigger the propagation oferrortrueinto login form component.Fixes #21