Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Setting fraction/integer digits should not be destructive #339

Closed
vaadin-miki opened this issue Jan 10, 2022 · 2 comments · Fixed by #340
Closed

Setting fraction/integer digits should not be destructive #339

vaadin-miki opened this issue Jan 10, 2022 · 2 comments · Fixed by #340
Assignees
@vaadin-miki
Labels
bug Something isn't working
Projects
Number Fields
Milestone
0.11.2 - HasValue...

Comments

@vaadin-miki
Copy link
Owner

Modifying fraction/integer digits should not be destructive to the value of the field.

Introduced as a side effect of implementing #337 - reported there as not wanted.
@vaadin-miki vaadin-miki added the bug Something isn't working label Jan 10, 2022
@vaadin-miki vaadin-miki added this to the Next release milestone Jan 10, 2022
@vaadin-miki vaadin-miki self-assigned this Jan 10, 2022
@vaadin-miki vaadin-miki added this to To do in Number Fields via automation Jan 10, 2022
@vaadin-miki vaadin-miki mentioned this issue Jan 10, 2022
Closed
@weiliang2
Copy link

Hello,

really appreciate your effort to look into this. Hope to hear some good news.

vaadin-miki added a commit that referenced this issue Jan 11, 2022
@vaadin-miki
#339 fixed, hopefully
4eeea5c 
digit changes should no longer be destructive
vaadin-miki added a commit that referenced this issue Jan 11, 2022
@vaadin-miki
#339 updated javadoc
ad28708
@vaadin-miki vaadin-miki mentioned this issue Jan 11, 2022
Merged
Number Fields automation moved this from To do to Done Jan 11, 2022
vaadin-miki added a commit that referenced this issue Jan 11, 2022
@vaadin-miki
#339 non-destructive format changes (#340)
56f5b80 
* #339 fixed, hopefully - format digit changes should no longer be destructive
@vaadin-miki
Copy link
Owner Author

@weiliang2 according to the tests those changes should now no longer be destructive - will do my best to make a new release this week (or early next week)

vaadin-miki added a commit that referenced this issue Jan 13, 2022
@vaadin-miki
Release 0.11.2 ready (#344)
9bb7e62 
* #337 valuechangemode and clear buttons (#338)
* #339 non-destructive format changes (#340)
* #341 updated docs (#342)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vaadin-miki vaadin-miki

Labels
bug Something isn't working
Projects
Number Fields
  
Done
Milestone
0.11.2 - HasValueChangeMode
Development

Successfully merging a pull request may close this issue.

#339 non-destructive format changes vaadin-miki/super-fields
2 participants
@vaadin-miki @weiliang2