Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove button theme override #418

Closed
jouni opened this issue Feb 2, 2018 · 1 comment
Closed

Remove button theme override #418

jouni opened this issue Feb 2, 2018 · 1 comment

Comments

@jouni
Copy link
Member

jouni commented Feb 2, 2018

This style override needs to be removed: https://github.com/vaadin/bakery-app-starter-flow-spring/blob/master/src/main/webapp/frontend/src/styles/shared-styles.html#L180-L183

There are very few exceptions when you need to do any customization to the visual styles of Vaadin elements. This is not one of them 😃
johannesh2 added a commit that referenced this issue Feb 7, 2018
@johannesh2
According to Jouni in #418 vaadin-button style override should be rem…
edc6029 
…oved
manolo pushed a commit that referenced this issue Feb 7, 2018
@johannesh2 @manolo
According to Jouni in #418 vaadin-button style override is not needed (…
6d804ea 
…#428)

* According to Jouni in #418 vaadin-button style override should be removed
@johannesh2
Copy link
Contributor

Fixed in 6d804ea

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jouni @johannesh2