Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mobile view UX fixes #453

Closed
eeroma opened this issue Feb 15, 2018 · 11 comments
Closed

Mobile view UX fixes #453

eeroma opened this issue Feb 15, 2018 · 11 comments

Comments

@eeroma
Copy link

eeroma commented Feb 15, 2018

nayttokuva 2018-2-15 kello 11 18 28

The mobile view seems really crowded atm and the overflowing text in the cards make it seem unfinished. Suggested fixes:

  • Fix issue nr. The visual balance of icons and labels is off #452 to fix the inbalance between icons and labels
  • Make the time section inside the card 100% and make the content inline.
  • Make the Card details (name, content etc.) 100% underneath the time section and do not show content that overflows or wrap the content if it's too long.
  • Fix the font sizes in the bottom navigation on mobile so that they don't overlap and make the icons a couple of pixels smaller. (on 320px viewport width)
@jouni
Copy link
Member

jouni commented Feb 18, 2018

Thanks for the feedback!

As a guideline, try to focus only on pointing out issues, without prescribing fixes at the same time. The team is responsible for working with the product designers in finding correct solutions.

That said, I’m more than willing to spend time with the team to polish the UI if there is genuine interest in when the team has time to focus making the app look pretty and polished.

@jouni
Copy link
Member

jouni commented Feb 18, 2018

There seem to be some weird bugs in the bakery styling that cause a lot of these issues.

For example, when inspecting the app, the body element has height: 0.1px as inline style. Where does that come from?

@manolo
Copy link
Member

manolo commented Feb 19, 2018

body styles in the hosted page are defined via @BodySize flow annotation
https://github.com/vaadin/bakery-app-starter-flow-spring/blob/master/src/main/java/com/vaadin/starter/bakery/ui/MainView.java#L47

@manolo
Copy link
Member

manolo commented Mar 2, 2018

Seems not be an issue anymore. Closing it.

screen shot 2018-03-02 at 10 47 43

@manolo manolo closed this as completed Mar 2, 2018
@jouni
Copy link
Member

jouni commented Mar 2, 2018

Is the online demo updated to show these fixes? At least bakery-flow.demo.vaadin.com looks different on iOS than the screenshot above.

@jouni
Copy link
Member

jouni commented Mar 2, 2018

Same thing with bakery-flow-spring.app.fi

screen shot 2018-03-02 at 13 31 10

@alexberazouski alexberazouski reopened this Mar 2, 2018
@manolo
Copy link
Member

manolo commented Mar 2, 2018

Actually is updated, but for some reason the media query in iOS does not matches, interesting ...

@manolo
Copy link
Member

manolo commented Mar 2, 2018

Seems a problem with bundling, the fix works in dev-mode but not when bundled.

This is the PR that apparently should fix the issue #484

@jouni any clue

@alexberazouski
Copy link

Seems it's bakery styling issue; reproduced on safari desktop.

@alexberazouski
Copy link

Is any of described bugs still an issue? I cannot reproduce it anymore

@johannesh2
Copy link
Contributor

Closing as fixed. Please re-open if needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants