Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The visual balance of icons and labels is off #452

Closed
eeroma opened this issue Feb 15, 2018 · 5 comments
Closed

The visual balance of icons and labels is off #452

eeroma opened this issue Feb 15, 2018 · 5 comments

Comments

@eeroma
Copy link

eeroma commented Feb 15, 2018

nayttokuva 2018-2-15 kello 12 49 55 kopio

The icons are way more bigger than the icons in both the search input and the icon buttons which make them look ugly. Also the label of the search is straight in the center but the buttons "New..." text is slightly to the top vertically. Line-height issue?

@jouni
Copy link
Member

jouni commented Feb 18, 2018

Related #461

@jouni
Copy link
Member

jouni commented Feb 18, 2018

The icon sizes should now be fixed in vaadin-button, vaadin-text-field and vaadin-tabs master.

The icon vertical alignment should be fixed by Flow at some point, when they migrate their button implementation to use the prefix and suffix slots inside the button (which are meant for icons).

@johannesh2
Copy link
Contributor

@eeroma Is this better now. We are using prefix slots and the icon sizes are 16px?

@manolo
Copy link
Member

manolo commented Mar 2, 2018

We are using stock vaadin elements with vaadin:icons in prefix/suffix, and the problem seems to have disappeared. Hence not a problem in bakery anymore, but in core theme in case is comes again.
@eeroma could you verify that it works for you, and close this ?

@johannesh2
Copy link
Contributor

johannesh2 commented May 15, 2018

Closing as fixed. Please re-open if needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants