CCDM: use v15 alpha #953
Merged
CCDM: use v15 alpha #953
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11 tasks
manolo
approved these changes
Oct 9, 2019
There was a problem hiding this comment.
Reviewed 2 of 2 files at r2, 3 of 3 files at r3.
Reviewable status:complete! all files reviewed, all discussions resolved
vlukashov
approved these changes
Oct 10, 2019
There was a problem hiding this comment.
Reviewed 2 of 2 files at r2, 3 of 3 files at r4.
Reviewable status:
vlukashov
approved these changes
Oct 10, 2019
There was a problem hiding this comment.
Reviewed 9 of 9 files at r5.
Reviewable status:
manolo
approved these changes
Oct 10, 2019
There was a problem hiding this comment.
Reviewed 9 of 9 files at r5.
Reviewable status:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues found during this PR:
flow.startdoesn't work correctly in this project. In the bakery, it is configured with Spring to do the authentication at the URL/login. We are asking for initialization with a GET request/login?v-r=init.....It's fine and the server responses the configuration for flow-client to initialize the client engine. However, client-engine seems to take that URL prefix,/login, as the base URL for later RPC requests, the next request they send is a POST request/login?v-r=uidl.....Then that request is caught by Spring and considered as an authentication request.Fixed in CCDM: consider servlet context when server navigation flow#6638
This change is